0005685: Antiquotation bug (quotation expr, with antiquotation list)

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0005685

OCaml

Camlp4

public

2012-07-13 16:51

2012-09-21 14:49

Reporter

hongboz

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

acknowledged

Resolution

open

Platform

OS Version

Product Version

Target Version

4.00.2+dev

Fixed in Version

Summary

0005685: Antiquotation bug (quotation expr, with antiquotation list)

Description

value f x = <:expr< $list:x$ >> ;
will be accepted and the type is weird
list Ast.ident -> Ast.expr (This absolutely not what I want)
The problem comes from that in the parser entry
expr accept TRY val_longident which accept ANTIQUOT, and the context is changed.
I guess there maybe other similar bugs in other places. The patch is attached, plz review the patch. Thanks
Another problem, I added some tracing functionality for the parser in my in-home camlp4 which helps me a lot to pinpoint the problem. How about the idea to add some tracing for the parser?

Tags

No tags attached.

Attached Files

revised.patch [^] (1,232 bytes) 2012-07-13 16:51 [Show Content] [Hide Content]

diff --git a/camlp4/Camlp4Parsers/Camlp4OCamlRevisedParser.ml b/camlp4/Camlp4Parsers/Camlp4OCamlRevisedParser.ml
index edd5fe0..d211599 100644
--- a/camlp4/Camlp4Parsers/Camlp4OCamlRevisedParser.ml
+++ b/camlp4/Camlp4Parsers/Camlp4OCamlRevisedParser.ml
@@ -697,7 +697,7 @@ New syntax:\
         | s = a_CHAR -> <:expr< $chr:s$ >>
         | i = TRY module_longident_dot_lparen; e = sequence; ")" ->
             <:expr< let open $i$ in $e$ >>
-        | i = TRY val_longident -> <:expr< $id:i$ >>
+        | i = TRY ident_without_antiquot -> <:expr< $id:i$ >>
         | "`"; s = a_ident -> <:expr< ` $s$ >>
         | "["; "]" -> <:expr< [] >>
         | "["; mk_list = sem_expr_for_list; "::"; last = expr; "]" ->
@@ -1198,6 +1198,13 @@ New syntax:\
             <:ident< $anti:mk_anti ~c:"ident" n s$.$i$ >>
         | i = a_UIDENT; "."; j = SELF -> <:ident< $uid:i$.$j$ >> ] ]
     ;
+    ident_without_antiquot:
+      [ [
+        i = a_UIDENT -> <:ident< $uid:i$ >>
+        | i = a_LIDENT -> <:ident< $lid:i$ >>
+        | i = a_UIDENT; "."; j = SELF -> <:ident< $uid:i$.$j$ >> ] ]
+    ;
+
     module_longident:
       [ [ `ANTIQUOT (""|"id"|"anti"|"list" as n) s ->
             <:ident< $anti:mk_anti ~c:"ident" n s$ >>

Relationships

Notes
(0007751) hongboz (developer) 2012-07-13 17:25	Sorry, this may not be considered a bug, it may intensionally designed this way

(0007752) hongboz (developer) 2012-07-13 17:32	I think it's better to document this unexpected behavior. Since the parser expr fails it will try to use the parser ident, ident happens to support list antiquot which people in general may thought it's expr that parse the antiquot, actually not.

Issue History
Date Modified	Username	Field	Change
2012-07-13 16:51	hongboz	New Issue
2012-07-13 16:51	hongboz	File Added: revised.patch
2012-07-13 17:25	hongboz	Note Added: 0007751
2012-07-13 17:32	hongboz	Note Added: 0007752
2012-07-17 14:50	doligez	Status	new => acknowledged
2012-07-17 14:50	doligez	Target Version	=> 4.01.0+dev
2012-07-31 13:36	doligez	Target Version	4.01.0+dev => 4.00.1+dev
2012-09-21 14:49	doligez	Target Version	4.00.1+dev => 4.00.2+dev