0005692: regression: end locations wrong in camlp4 ast

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0005692

OCaml

Camlp4

public

2012-07-20 10:52

2012-07-20 11:27

Reporter

Hendrik Tews

Assigned To

dim

Priority

normal

Severity

major

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

4.00.0+beta2/+rc1

Target Version

Fixed in Version

4.00.0+beta2/+rc1

Summary

0005692: regression: end locations wrong in camlp4 ast

Description

Somewhere inside the camlp4 machinery, end locations are not
propagated any more. The result is that for many nodes in the camlp4
ast the end location is identical to the start location.

Severity major, because this will very likely break otags. Because of
missing or wrong location info, otags reparses fragments of the source.
In some cases it has to take the last or second last word. This can of
course only work with correct end locations.

For example, for "exception A of int" I see for the top StExc node

start_line 1, start_offset 0, end_line 1, end_offset 0

for "type t = int" I see for the top StTyp node

start_line 1, start_offset 0, end_line 1, end_offset 0

and there are many more cases...

Tags

No tags attached.

Attached Files

Relationships

Notes
(0007786) dim (developer) 2012-07-20 11:27	Fixed. Commits 12751 and 12752.

Issue History
Date Modified	Username	Field	Change
2012-07-20 10:52	Hendrik Tews	New Issue
2012-07-20 11:27	dim	Assigned To	=> dim
2012-07-20 11:27	dim	Status	new => resolved
2012-07-20 11:27	dim	Resolution	open => fixed
2012-07-20 11:27	dim	Fixed in Version	=> 4.00.0+beta2/+rc1
2012-07-20 11:27	dim	Note Added: 0007786