Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmx magic numbers have not been changed for a while #5704

Closed
vicuna opened this issue Jul 28, 2012 · 1 comment
Closed

cmx magic numbers have not been changed for a while #5704

vicuna opened this issue Jul 28, 2012 · 1 comment

Comments

@vicuna
Copy link

vicuna commented Jul 28, 2012

Original bug ID: 5704
Reporter: @lefessan
Status: closed (set by @alainfrisch on 2013-07-09T11:12:44Z)
Resolution: fixed
Priority: normal
Severity: trivial
Version: 4.00.0
Target version: 4.01.0+dev
Fixed in version: 4.01.0+dev
Category: back end (clambda to assembly)
Monitored by: @glondu @mmottl

Bug description

It looks like cmx magic numbers have not been changed since commit 7812, but last changes to the Clambda.ulambda (used for inlined function code in .cmx) have commit numbers 11007 and 12179.

Some people have noticed segfaults of ocamlopt/ocamlopt.opt due to heap corruption. Is it possible that these segfaults come from .cmx files of older versions ? (I open this bug report so that such problems can be linked to this bug report as a possible cause)

@vicuna
Copy link
Author

vicuna commented Sep 24, 2012

Comment author: @xavierleroy

I agree that updating the magic numbers wouldn't hurt. On the other hand, I don't think magic number confusion is causing the heap corruption in question --- #5757 looks like a more likely culprit. So, I propose to schedule this update for 4.01 and leave it out of the bugfix release 4.00.1.

@vicuna vicuna closed this as completed Jul 9, 2013
@vicuna vicuna added this to the 4.01.0 milestone Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant