0005742: no bound checks anymore on some array operations

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0005742

OCaml

OCaml standard library

public

2012-08-28 00:02

2012-08-28 17:10

Reporter

lefessan

Assigned To

Priority

high

Severity

crash

Reproducibility

always

Status

resolved

Resolution

open

Platform

OS Version

Product Version

4.00.0

Target Version

Fixed in Version

4.00.1+dev

Summary

0005742: no bound checks anymore on some array operations

Description

$ ocaml
        OCaml version 4.00.0

# Array.sub [||] 0 10;;
- : '_a array =
[|<poly>; <poly>; <poly>; <poly>; <poly>; <poly>; <poly>; <poly>; <poly>;
  <poly>|]
#

probably since commit 11913:

Module Array: faster implementations of "blit", "copy", "sub",
  "append" and "concat" (PR#2395, PR#2787, PR#4591)

Tags

No tags attached.

Attached Files

Relationships

Notes
(0007991) xleroy (administrator) 2012-08-28 17:10	Indeed, the bound check in Array.sub fell through the cracks during commit 11913. Reinstated proper bound checks + a test in the testsuite, commits r12891 (4.00 bugfix branch) and r12892 (trunk).

Issue History
Date Modified	Username	Field	Change
2012-08-28 00:02	lefessan	New Issue
2012-08-28 17:10	xleroy	Note Added: 0007991
2012-08-28 17:10	xleroy	Status	new => resolved
2012-08-28 17:10	xleroy	Fixed in Version	=> 4.00.1+dev