New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes for tools/pprintast.ml #5775
Comments
Comment author: @gasche The patch looks reasonable (but why all those commented lines in the Pcl_fun case?). I haven't looked into it in the details, but given that the original code is quite shaky anyway I think this will be an improvement -- and there are a couple glaring bug fixed by the commit. As a side remark, could you format your diff in the so-called "unified" format (diff -u)? They're much easier to read online because they provide context around the changes. I think using the unified format is pretty much the standard now, and I will upload a unified version of your patch for future potential reviewers. |
Comment author: @bobzhang sure, thanks for your new patch |
Comment author: @bobzhang lefessan, would you have a look at this patch? |
Comment author: @bobzhang I have updated more bug fixes for this file, it was heavily tested |
Comment author: @bobzhang gasche, is there any guidelines to commit? I want to read some instructions before I do my first commit. |
Comment author: @damiendoligez We don't (yet) have written guidelines. Off the top of my head:
Step (4) is optional for small changes. Asking for a code review (as you did) is also a good idea, unless it's a small change and you know what you're doing. |
Comment author: @damiendoligez I have committed the second patch (pprintast1.patch) to 4.00 (rev 13015) and trunk (rev 13016). |
Original bug ID: 5775
Reporter: @bobzhang
Assigned to: @bobzhang
Status: closed (set by @xavierleroy on 2015-12-11T18:08:15Z)
Resolution: fixed
Priority: normal
Severity: minor
Fixed in version: 4.00.2+dev
Category: ~DO NOT USE (was: OCaml general)
Monitored by: @hcarty
Bug description
I have attached some bug fixes for tools/pprintast.ml, currently I use tools/pprintast.ml to bootstrapping camlP4, if the community reach a consensus that we should have a high quality printer for Parsetree to get valid vanilla ocaml code, I would be happy to spend more time to get a beautiful output
Please review the patch
File attachments
The text was updated successfully, but these errors were encountered: