0005820: move_start_p in Lexing is wrong

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0005820

OCaml

Camlp4

public

2012-11-11 17:29

Reporter

hongboz

Assigned To

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0005820: move_start_p in Lexing is wrong

Description

the move_start_p want to unrolling some characters, but it does not have any side effect actually.
given a string input
"*)" it can only generate tokens "SYMBOL *".

the ocamllex manual does not say it can do unrolling, but I have a hack that will do this
        | "*)"
           { warn Comment_not_end (FanLoc.of_lexbuf lexbuf) ;
             (* move_start_p (-1) c; *)
             lexbuf.lex_curr_pos <- lexbuf.lex_curr_pos - 1;
             SYMBOL "*" }

Will anyone verify this problem? the move_start_p should be removed and applied such hacks to unroll

Issue History
Date Modified	Username	Field	Change
2012-11-11 17:29	hongboz	New Issue

Relationships

Notes
There are no notes attached to this issue.