Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept piping typedtree #5871

Closed
vicuna opened this issue Jan 2, 2013 · 3 comments
Closed

accept piping typedtree #5871

vicuna opened this issue Jan 2, 2013 · 3 comments

Comments

@vicuna
Copy link

vicuna commented Jan 2, 2013

Original bug ID: 5871
Reporter: @bobzhang
Status: resolved (set by @xavierleroy on 2015-11-23T14:10:31Z)
Resolution: suspended
Priority: normal
Severity: feature
Category: ~DO NOT USE (was: OCaml general)

Bug description

pre-processor will be enhanced if given type information, currently the way to go is back and forth between typedtree and parsetree (for the whole file) which takes too much time.

if this is accepted, we can incrementally typing each phrase, then only for the typedtree which needs rewriting, we do the type and untype cycle, which saves a lot of time and you don't pay if you don't do the typedtree re-writing.

The change to the compiler is minimal

@vicuna
Copy link
Author

vicuna commented Jan 5, 2013

Comment author: @alainfrisch

Can your be more explicit about the proposed change?

@vicuna
Copy link
Author

vicuna commented Jan 5, 2013

Comment author: @bobzhang

I may upload a patch next week, it's something similar to allow piping raw ast

@vicuna
Copy link
Author

vicuna commented Nov 23, 2015

Comment author: @xavierleroy

This PR has been inactive for too long. Suspending it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant