Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the compiler library interface #5940

Closed
vicuna opened this issue Mar 7, 2013 · 2 comments
Closed

Clean up the compiler library interface #5940

vicuna opened this issue Mar 7, 2013 · 2 comments

Comments

@vicuna
Copy link

vicuna commented Mar 7, 2013

Original bug ID: 5940
Reporter: @bobzhang
Assigned to: @bobzhang
Status: closed (set by @xavierleroy on 2015-12-11T18:18:53Z)
Resolution: fixed
Priority: normal
Severity: feature
Category: ~DO NOT USE (was: OCaml general)
Monitored by: @gasche

Bug description

I just take a look at how Fan depends on the compiler library today, and find that the dependency is quite minimal, but with a bit clean up in the compiler library, maybe it could remove the dependency on the compiler library.

Dependency on the compiler related:

Config.ast_intf_magic_number
Config.ast_intf_magic_number
(* suggestions: move them to Sys library*)

parsetree.mli
location.mli
longident.mli

(* suggestion:
location.ml and longident.ml may be could be removed following the same convention as parseetree.mli
and then distributed with the standard library
*)

typedtree.mli
types.mli
cmi_format.ml
(*
These are advanced features provided by Fan, so maybe it is acceptable to linking with the compiler
*)
Thanks

@vicuna
Copy link
Author

vicuna commented May 28, 2013

Comment author: @bobzhang

I plan to change function print_config in utils/config.mlp and config.mlbuild to print the magic number so that we could get rid of the linking dependency on compiler-libs for Fan.
Since the change is modest, if nobody opposes, I would do it later

@vicuna
Copy link
Author

vicuna commented May 28, 2013

Comment author: @bobzhang

fixed in revision 13709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant