Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error in tools/Makefile.shared #5991

Closed
vicuna opened this issue Apr 18, 2013 · 4 comments
Closed

Syntax error in tools/Makefile.shared #5991

vicuna opened this issue Apr 18, 2013 · 4 comments

Comments

@vicuna
Copy link

vicuna commented Apr 18, 2013

Original bug ID: 5991
Reporter: PedroBurito
Status: closed (set by @xavierleroy on 2016-12-07T10:47:04Z)
Resolution: unable to duplicate
Priority: normal
Severity: minor
Platform: armv5tejl
OS: Linux
OS Version: 2.6.24.4
Version: 4.00.1
Target version: 4.02.2+dev / +rc1
Category: configure and build/install
Tags: patch

Bug description

I tried building ocaml from source and i got stuck with an error. i think there's missing a \ in on of the sed expressions which generates the opnames.ml file.
i provided a diff -u in the additional info section which hopefully resolves the issue.
gnu sed 4.2.2

Additional information

--- Makefile.shared 2013-04-18 19:33:55.000000000 +0200
+++ Makefile.shared.bugged 2013-04-18 19:39:29.000000000 +0200
@@ -254,7 +254,7 @@
unset LC_COLLATE LANG || : ;
sed -e '//*/d'
-e '/^#/d' \

  •       -e 's/enum \(.*\) {/let names_of_\1 = \[|/' \
    
  •       -e 's/enum \(.*\) {/let names_of_\1 = [|/' \
          -e 's/};$$/ |]/' \
          -e 's/\([A-Z][A-Z_0-9a-z]*\)/"\1"/g' \
          -e 's/,/;/g' \
    
@vicuna
Copy link
Author

vicuna commented Apr 29, 2013

Comment author: @alainfrisch

What's the error? At least with gnu sed 4.2.1, it seems to work fine.

@vicuna
Copy link
Author

vicuna commented Apr 29, 2013

Comment author: PedroBurito

Sorry, i got the diff the wrong way around.
The missing \ before the [ after /let names_of_\1 = ..... made my sed fail and the makefile therefore created an empty file instead of the command listing or whatever the file actually is :)

@vicuna
Copy link
Author

vicuna commented Jun 19, 2013

Comment author: @damiendoligez

Are you sure this is really the problem? I have a hard time believing that GNU sed would introduce such a big change in a bug-fix release (between 4.2.1 and 4.2.2). I also find it strange that 4.2.2 was released, but the on-line documentation on the GNU web site is still for 4.2.1.

Moreover, the man page for a "normal" sed (Mac OS X) doesn't seem to say that arbitrary characters can be escaped in the replacement string, so this is not supposed to work. It does work on MacOS, but what about the other BSDs, for example?

I don't think we want to risk including this fix before the 4.01.0 release.

@vicuna
Copy link
Author

vicuna commented Sep 24, 2014

Comment author: @damiendoligez

I've tried with GNU sed 4.2.2 compiled from sources, and it works perfectly.

It looks like your version of sed is not a genuine GNU sed. Which Linux distribution are you using?

@vicuna vicuna closed this as completed Dec 7, 2016
@vicuna vicuna added this to the 4.02.2 milestone Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant