Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0006073OCamlOCaml generalpublic2013-07-11 16:592013-07-18 22:00
Assigned Tofrisch 
PlatformOSOS Version
Product Version4.00.1 
Target Version4.01.0+devFixed in Version4.01.0+dev 
Summary0006073: Add signature to Tstr_include
DescriptionAt the moment Tstr_include has the definition:

  Tstr_include of module_expr * Ident.t list

where the second field lists the value idents defined by the include. This means that there is no way (easy) way to tell what non-value idents are defined by the include.

It would be better if it kept the full included signature (like Tsig_include does):

  Tstr_include of module_expr * Types.signature

I've attached a small patch to make this change. It would be quite useful if this could be included in 4.01.0 as it will make generating documentation from .cmt files easier.
TagsNo tags attached.
Attached Filespatch file icon sig_tstr_include.patch [^] (8,506 bytes) 2013-07-11 16:59 [Show Content]

- Relationships

-  Notes
frisch (developer)
2013-07-11 17:19

What about using the mod_type field of the module_expr argument? (If it is a Mty_signature, you have it. Maybe it can also be a Mty_ident -- I'm not sure -- in that case you need to use Mtype.scrape on it.)
lpw25 (developer)
2013-07-11 17:39

I don't think the idents accessible via the mod_type field are the right ones because they get renamed before they are included.
frisch (developer)
2013-07-17 14:01

> because they get renamed before they are included.

Indeed! I'll merge the patch.
frisch (developer)
2013-07-17 17:26

Commit 13903 on 4.01, 13904 on trunk.

- Issue History
Date Modified Username Field Change
2013-07-11 16:59 lpw25 New Issue
2013-07-11 16:59 lpw25 File Added: sig_tstr_include.patch
2013-07-11 17:19 frisch Note Added: 0009755
2013-07-11 17:39 lpw25 Note Added: 0009756
2013-07-17 14:01 frisch Assigned To => frisch
2013-07-17 14:01 frisch Status new => assigned
2013-07-17 14:01 frisch Note Added: 0009800
2013-07-17 17:26 frisch Note Added: 0009803
2013-07-17 17:26 frisch Status assigned => resolved
2013-07-17 17:26 frisch Fixed in Version => 4.01.0+dev
2013-07-17 17:26 frisch Resolution open => fixed

Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker