Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrincipalFlag test broken for ocamlbuild #6129

Closed
vicuna opened this issue Aug 12, 2013 · 2 comments
Closed

PrincipalFlag test broken for ocamlbuild #6129

vicuna opened this issue Aug 12, 2013 · 2 comments

Comments

@vicuna
Copy link

vicuna commented Aug 12, 2013

Original bug ID: 6129
Reporter: kerneis
Assigned to: @gasche
Status: closed (set by @xavierleroy on 2015-12-11T18:23:49Z)
Resolution: duplicate
Priority: normal
Severity: minor
Version: 4.00.1
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues
Related to: #6060
Monitored by: kerneis

Bug description

The attached patch fixes the issue: the error message is checked only once, but printed twice since we try to build two targets (.byte and .native). This makes me wonder if anybody actually runs those regression tests, though...

File attachments

@vicuna
Copy link
Author

vicuna commented Aug 13, 2013

Comment author: @gasche

I reported this issue in the bugtracker discussion of the corresponding patch, #6060#c10137 , but decided to wait for either Anil or Wojciech to confirm.

@vicuna
Copy link
Author

vicuna commented Aug 13, 2013

Comment author: kerneis

I think you can close this issue, since the correct fix is more likely to either use my patch proposal on 6060 for permissive matching, or build only one of the targets as you suggested there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants