Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patchset RFC] reorganize the ocamlbuild testsuite #6132

Closed
vicuna opened this issue Aug 18, 2013 · 1 comment
Closed

[patchset RFC] reorganize the ocamlbuild testsuite #6132

vicuna opened this issue Aug 18, 2013 · 1 comment
Assignees
Milestone

Comments

@vicuna
Copy link

vicuna commented Aug 18, 2013

Original bug ID: 6132
Reporter: @gasche
Assigned to: @gasche
Status: closed (set by @xavierleroy on 2015-12-11T18:24:08Z)
Resolution: fixed
Priority: normal
Severity: feature
Target version: 4.01.1+dev
Fixed in version: 4.02.0+dev
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues

Bug description

The attached patchset reorganizes the ocamlbuild testsuite, with the aim to make it easier to run some of the test from a bare OCaml installation (without ocamlfind, menhir, and some of the other things supported by ocamlbuild and for which some tests exists). The patch splits the tests in three files instead of level0.ml:

  • internal.ml for tests that have no external dependency at all
  • findlibonly.ml for tests that only rely on ocamlfind/findlib
  • external.ml for the rest, with logic to skip tests depending on not-installed packages

commits
[1/4] ocamlbuild testsuite: add a "requirements" field to skip tests we cannot run
[2/4] ocamlbuild testsuite: factorize the color-code magic
[3/4] ocamlbuild testsuite: split level0.ml into internal.ml, findlibonly.ml, external.ml
[4/4] ocamlbuild testsuite: fix the PrincipalFlag test

File attachments

@vicuna
Copy link
Author

vicuna commented Sep 15, 2013

Comment author: @gasche

Committed in trunk.

@vicuna vicuna closed this as completed Dec 11, 2015
@vicuna vicuna added this to the 4.01.1 milestone Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants