Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning when using -plugin-tag(s) without myocamlbuild.ml #6187

Closed
vicuna opened this issue Sep 21, 2013 · 4 comments
Closed

Add a warning when using -plugin-tag(s) without myocamlbuild.ml #6187

vicuna opened this issue Sep 21, 2013 · 4 comments
Assignees

Comments

@vicuna
Copy link

vicuna commented Sep 21, 2013

Original bug ID: 6187
Reporter: jpdeplaix
Assigned to: @gasche
Status: closed (set by @xavierleroy on 2015-12-11T18:25:56Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.01.0
Fixed in version: 4.02.0+dev
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues
Tags: patch

Bug description

If I'm right, the -plugin-tag(s) option is inefficient when using without a myocamlbuild.ml. It would be great to have a warning in case of the file would be not there.

Additional information

The attached patch fixes this issue.

File attachments

@vicuna
Copy link
Author

vicuna commented Sep 21, 2013

Comment author: @gasche

I'm not sure what you mean by "is inefficient"; the -plugin-tags option is, semantically, independent from -use-ocamlfind, as you can specify any kind of tags ocamlbuild understands. If you don't pass -use-ocamlfind you cannot use the parametrized tags "package(foo)", just like in the _tags file -- and I think there is a warning about the surprising arity.

@vicuna
Copy link
Author

vicuna commented Sep 21, 2013

Comment author: jpdeplaix

Mmh, I'm not sure :/ How -use-ocamlfind is linked to what I'm asking ?

@vicuna
Copy link
Author

vicuna commented Sep 22, 2013

Comment author: @gasche

Sorry, I misread the report as "inefficient when used without ocamlfind".

@vicuna
Copy link
Author

vicuna commented Mar 20, 2014

Comment author: @gasche

Included in trunk (14475).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants