Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"sed: comment garbled" on make world #6214

Closed
vicuna opened this issue Oct 28, 2013 · 4 comments
Closed

"sed: comment garbled" on make world #6214

vicuna opened this issue Oct 28, 2013 · 4 comments

Comments

@vicuna
Copy link

vicuna commented Oct 28, 2013

Original bug ID: 6214
Reporter: @johnwhitington
Assigned to: @mshinwell
Status: closed (set by @damiendoligez on 2014-02-19T15:34:59Z)
Resolution: not a bug
Priority: normal
Severity: minor
OS: Solaris
OS Version: 8
Version: 4.01.0
Fixed in version: 4.02.0+dev
Category: configure and build/install

Bug description

A customer is trying to build our software on Solaris 8 (they had built successfully with 3.10.2 a number of years back on this same machine).

But with 4.01.0, they get:

sed -e 's|%%LIBDIR%%|/usr/local/lib/ocaml|'
-e 's|%%BYTERUN%%|/usr/local/bin/ocamlrun|'
-e 's|%%CCOMPTYPE%%|cc|'
-e 's|%%BYTECC%%|gcc -fno-defer-pop -Wall -D_FILE_OFFSET_BITS=64 -D_REENTRANT -fPIC|'
-e 's|%%NATIVECC%%|gcc -Wall -D_FILE_OFFSET_BITS=64 -D_REENTRANT|'
-e 's|%%PACKLD%%|ld -r -o|'
-e 's|%%BYTECCLIBS%%|-lnsl -lsocket -lm -ldl -lcurses -lpthread -lposix4|'
-e 's|%%NATIVECCLIBS%%|-lnsl -lsocket -lm -ldl|'
-e 's|%%RANLIBCMD%%|ranlib|'
-e 's|%%ARCMD%%|ar|'
-e 's|%%CC_PROFILE%%|-pg|'
-e 's|%%ARCH%%|sparc|'
-e 's|%%MODEL%%|default|'
-e 's|%%SYSTEM%%|solaris|'
-e 's|%%EXT_OBJ%%|.o|'
-e 's|%%EXT_ASM%%|.s|'
-e 's|%%EXT_LIB%%|.a|'
-e 's|%%EXT_DLL%%|.so|'
-e 's|%%SYSTHREAD_SUPPORT%%|true|'
-e 's|%%ASM%%|as|'
-e 's|%%ASM_CFI_SUPPORTED%%|false|'
-e 's|%%WITH_FRAME_POINTERS%%|false|'
-e 's|%%MKDLL%%|gcc -shared|'
-e 's|%%MKEXE%%|gcc|'
-e 's|%%MKMAINDLL%%|gcc -shared|'
utils/config.mlp > utils/config.ml
sed: command garbled: s|%%PACKLD%%|ld -r -o|
*** Error code 2
make: Fatal error: Command failed for target utils/config.ml' Current working directory /export/home/admin/cpdf.solaris8.2013.10.28/ocaml-4.01.0 *** Error code 1 make: Fatal error: Command failed for target world'

The extra '' in the PACKLD line does indeed look superfluous or wrong, but I don't know anything about sed in general, or solaris sed in particular.

@vicuna
Copy link
Author

vicuna commented Oct 29, 2013

Comment author: @damiendoligez

What's missing is a space after that backslash. It was stripped off (probably by make or by the shell) from the PACKLD line in config/Makefile.

@vicuna
Copy link
Author

vicuna commented Oct 29, 2013

Comment author: @johnwhitington

Right, I will try with GNU make instead of solaris make, and see if that helps.

@vicuna
Copy link
Author

vicuna commented Oct 29, 2013

Comment author: @johnwhitington

Customer reports that GNU make works fine.

The INSTALL instructions do suggest GNU make quite strongly, so this is a false report and can be closed.

It's also worth mentioning that the INSTALL file says:


  • GNU make is needed to build ocamlbuild and camlp4. If your system's
    default make is not GNU make, you need to define the GNUMAKE environment
    variable to the name of GNU make, typically with this command:

    export GNUMAKE=gnumake


I've never seen "gnumake" used, but have seen several systems where it's installed as "gmake".

@vicuna
Copy link
Author

vicuna commented Feb 19, 2014

Comment author: @damiendoligez

Changed gnumake to gmake and added a warning about Solaris in the "common problems" section.
Done in trunk (rev 14438).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants