Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bound checking bug for the string_{get,set}{16,32,64} primitives #6261

Closed
vicuna opened this issue Dec 4, 2013 · 2 comments
Closed

bound checking bug for the string_{get,set}{16,32,64} primitives #6261

vicuna opened this issue Dec 4, 2013 · 2 comments
Assignees
Milestone

Comments

@vicuna
Copy link

vicuna commented Dec 4, 2013

Original bug ID: 6261
Reporter: @chambart
Assigned to: @chambart
Status: closed (set by @xavierleroy on 2015-12-11T18:27:56Z)
Resolution: fixed
Priority: normal
Severity: major
Version: 4.01.0
Target version: 4.02.0+dev
Category: back end (clambda to assembly)
Tags: patch
Monitored by: @gasche @hcarty

Bug description

There is a problem with bound checking in those primitives when (size - index) is lower than 0.

This can be solved quite cheaply by the provided patch.

Additional information

The bytecode part has already been solved by Gabriel Schrer

File attachments

@vicuna
Copy link
Author

vicuna commented Dec 4, 2013

Comment author: @chambart

The second patch is an addition to the testsuite.

@vicuna
Copy link
Author

vicuna commented Jun 5, 2014

Comment author: @chambart

Fixed in trunk and 4.02

@vicuna vicuna closed this as completed Dec 11, 2015
@vicuna vicuna added this to the 4.02.0 milestone Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants