You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The patchset changes the C API exposed in hash.h to make it digest-agnostic
(so as to make future changes simpler) and switches the hash function to
SipHash-2-4.
SipHash is a familly of cryptographically-strong hash functions which are
competitive (performance-wise) with MurmurHash, the hash function currently used. SipHash-2-4 ( https://131002.net/siphash/ ) is the recommended version of SipHash.
Preliminary benchmarks look good. However, they were done using the functorized
version of Hashtbl, and this specific proposal hasn't been benchmarked yet.
This patchset doesn't change the bit-width of the key and output (32 bits).
This weakens the hash function, compared to SipHash-2-4 as specified by its authors, but isn't fixable without breaking the API.
The text was updated successfully, but these errors were encountered:
Original bug ID: 6366
Reporter: @gasche
Status: closed (set by @alainfrisch on 2016-12-07T17:43:47Z)
Resolution: suspended
Priority: normal
Severity: feature
Version: 4.02.0+dev
Category: standard library
Tags: github, patch
Bug description
#24
The patchset changes the C API exposed in hash.h to make it digest-agnostic
(so as to make future changes simpler) and switches the hash function to
SipHash-2-4.
SipHash is a familly of cryptographically-strong hash functions which are
competitive (performance-wise) with MurmurHash, the hash function currently used. SipHash-2-4 ( https://131002.net/siphash/ ) is the recommended version of SipHash.
Preliminary benchmarks look good. However, they were done using the functorized
version of Hashtbl, and this specific proposal hasn't been benchmarked yet.
Caveats:
The testsuite hasn't been fixed yet (expected values changed for hashes)
Commits expected to change the behaviour of the hash function are nbraud@28bde97 ( https://github.com/nbraud/ocaml/commit/28bde97b8 ) and nbraud@7dde207 ( https://github.com/nbraud/ocaml/commit/7dde207fe )
This patchset doesn't change the bit-width of the key and output (32 bits).
This weakens the hash function, compared to SipHash-2-4 as specified by its authors, but isn't fixable without breaking the API.
The text was updated successfully, but these errors were encountered: