New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-dsource assertion failure with attributes or extensions #6377
Comments
Comment author: @alainfrisch Indeed, pprintast has not been adapted. I'm not very comfortable with this piece of code, so any contribution is appreciated (a good contribution could be to replace the code with a more basic closed-recursion implementation). |
Comment author: @mshinwell Are we proposing to fix this for 4.02? |
Comment author: @alainfrisch -dsource and pprintast are quite useful to debug ppx rewriters, but as I wrote earlier, I'm not the good candidate for fixing this. If I spend more time looking at this file, I'll end up rewriting it completely, and this won't happen before 4.02. |
Comment author: @lpw25 I'll have a look at this and other "assert false"s in pprintast.ml sometime this week. |
Comment author: @lpw25 The attached patch adds printing for all attributes and extensions. It also fixes some whitespace issues and assertion failures. |
Comment author: @alainfrisch Thanks! Committed to 4.02 (revision 14981) after fixing conflict with commit 14956. |
…eo White). git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@14981 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
Original bug ID: 6377
Reporter: @lpw25
Assigned to: @lpw25
Status: closed (set by @xavierleroy on 2015-12-11T18:28:04Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.02.0+dev
Fixed in version: 4.02.0+dev
Category: ~DO NOT USE (was: OCaml general)
Tags: patch
Monitored by: @hcarty
Bug description
There are some assertions in pprintast.ml which mean -dsource doesn't always work with attributes and extensions:
File attachments
The text was updated successfully, but these errors were encountered: