You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Original bug ID: 6451 Reporter: furuse Assigned to:@alainfrisch Status: closed (set by @xavierleroy on 2015-12-11T18:28:00Z) Resolution: fixed Priority: normal Severity: minor Version: 4.02.0+beta1 / +rc1 Fixed in version: 4.02.0+dev Category: ~DO NOT USE (was: OCaml general) Tags: patch Monitored by:@gasche
Bug description
tools/untypeast.ml exists but not quite useful since it does not untype typed AST correctly. The results are often not compilable nor too different from the original.
This is not only the incompleteness of untypeast.ml but also due to the compiler bugs. So far I found:
Pwith_modsubst's lid is misused for other id's longident in typemod.ml.
Some structure items and class fields are listed in the reversed order in the typed AST.
The compiler changes the parsed AST during the type-checking, therefore it is natural that we cannot have 100% identical untyped AST from the source code. But at least it should be more compatible and compilable.
The text was updated successfully, but these errors were encountered:
I think untypeast may become important for 4.02 -ppx users, so we should considering bugfixing this in the release branch as well. I haven't looked at the patch yet so I cannot comment on its "safeness", but those type of roundtrip tests tend to be higly effective to improve correctness, so I would be rather confident.
Original bug ID: 6451
Reporter: furuse
Assigned to: @alainfrisch
Status: closed (set by @xavierleroy on 2015-12-11T18:28:00Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.02.0+beta1 / +rc1
Fixed in version: 4.02.0+dev
Category: ~DO NOT USE (was: OCaml general)
Tags: patch
Monitored by: @gasche
Bug description
tools/untypeast.ml exists but not quite useful since it does not untype typed AST correctly. The results are often not compilable nor too different from the original.
This is not only the incompleteness of untypeast.ml but also due to the compiler bugs. So far I found:
The compiler changes the parsed AST during the type-checking, therefore it is natural that we cannot have 100% identical untyped AST from the source code. But at least it should be more compatible and compilable.
The text was updated successfully, but these errors were encountered: