New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-exhaustive matching warning message for open types is confusing #6466
Comments
Comment author: @damiendoligez Let's have a discussion of what the error message should look like. |
Comment author: @whitequark Warning 8: this pattern-matching is not exhaustive. |
Comment author: @garrigue Fixed as suggested. Warning 8: this pattern-matching is not exhaustive. Removing the 2nd and 3rd line would require changing the warning definition. |
Comment author: @lpw25 For consistency with the documentation, could we change:
to
|
Comment author: @damiendoligez Reopened: let us discuss (or implement) Leo's proposed change to the warning message. |
Comment author: @whitequark gasche, can you please apply the trivial fix listed in the issue? |
Comment author: @gasche Merged in trunk and 4.02. |
Original bug ID: 6466
Reporter: @whitequark
Assigned to: @garrigue
Status: closed (set by @xavierleroy on 2016-12-07T10:37:16Z)
Resolution: fixed
Priority: normal
Severity: text
Version: 4.02.0+beta1 / +rc1
Target version: 4.02.2+dev / +rc1
Fixed in version: 4.02.1+dev
Category: ~DO NOT USE (was: OCaml general)
Monitored by: @gasche @hcarty
Bug description
Here it is:
I scratched my head for quite a while before I got it.
Steps to reproduce
function Not_found -> ()
File attachments
The text was updated successfully, but these errors were encountered: