Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0006477OCamlOCamldocpublic2014-07-04 12:192014-07-21 17:46
Reporterfuruse 
Assigned Todoligez 
PrioritynormalSeveritymajorReproducibilityalways
StatusassignedResolutionopen 
PlatformOSOS Version
Product Version4.01.0 
Target Versionafter-4.02.0Fixed in Version 
Summary0006477: Makefile.nt: odoc_info.cma and cmxa contain objects outside of ocamldoc
Descriptionocamldoc/Makefile.nt seems not to be up-to-date compared with ocamldoc/Makefile. It builds odoc_info.cma and odoc_info.cmxa with objects outside of ocamldoc, for example, typing/ident.cm{o,x}. This prevents from linking odoc_info.cm{a,xa} and compierlibs altogether in "NT" environment, since the both implements module Ident.


Tagspatch
Attached Files

- Relationships

-  Notes
(0011787)
furuse (reporter)
2014-07-04 12:21

The following diff shows how to fix the linking issue of odoc_info and ocamlcommon. But probably you may want to compare Makefile and Makefile.nt for other unapplied updates to Makefile.nt.



---------------------------------------



*** ocamldoc/Makefile.nt~ Tue Oct 16 01:50:56 2012
--- ocamldoc/Makefile.nt Fri Jul 4 17:33:24 2014
***************
*** 198,206 ****
      $(OCAMLOPT) -o $@ unix.cmxa str.cmxa dynlink.cmxa $(LINKFLAGS) $(OCAMLCMXFILES) $(EXECMXFILES)
  
  $(OCAMLDOC_LIBCMA): $(LIBCMOFILES)
! $(OCAMLC) -a -o $@ $(LINKFLAGS) $(OCAMLCMOFILES) $(LIBCMOFILES)
  $(OCAMLDOC_LIBCMXA): $(LIBCMXFILES)
! $(OCAMLOPT) -a -o $@ $(LINKFLAGS) $(OCAMLCMXFILES) $(LIBCMXFILES)
  
  # Parsers and lexers dependencies :
  ###################################
--- 198,206 ----
      $(OCAMLOPT) -o $@ unix.cmxa str.cmxa dynlink.cmxa $(LINKFLAGS) $(OCAMLCMXFILES) $(EXECMXFILES)
  
  $(OCAMLDOC_LIBCMA): $(LIBCMOFILES)
! $(OCAMLC) -a -o $@ $(LINKFLAGS) $(OCAMLSRCDIR)/tools/depend.cmo $(LIBCMOFILES)
  $(OCAMLDOC_LIBCMXA): $(LIBCMXFILES)
! $(OCAMLOPT) -a -o $@ $(LINKFLAGS) $(OCAMLSRCDIR)/tools/depend.cmx $(LIBCMXFILES)
  
  # Parsers and lexers dependencies :
  ###################################
(0011893)
doligez (administrator)
2014-07-21 17:46

I have tried to make Makefile and Makefile.nt as similar as possible without breaking anything (commit 15015).

As far as I can tell, the only significant difference is $(MAKEREC) vs $(MAKE) and we should merge these two files, then make Makefile.nt simply include Makefile. Keeping the PR open to this end.

- Issue History
Date Modified Username Field Change
2014-07-04 12:19 furuse New Issue
2014-07-04 12:19 furuse Status new => assigned
2014-07-04 12:19 furuse Assigned To => guesdon
2014-07-04 12:21 furuse Note Added: 0011787
2014-07-08 10:47 doligez Target Version => 4.02.0+dev
2014-07-17 12:23 doligez Tag Attached: patch
2014-07-17 12:23 doligez Assigned To guesdon => doligez
2014-07-21 17:46 doligez Note Added: 0011893
2014-07-21 17:46 doligez Target Version 4.02.0+dev => after-4.02.0
2014-07-21 17:46 doligez Summary Makefile.nt: odoc_info.cma and cmxa contain objects oustide of ocamldoc => Makefile.nt: odoc_info.cma and cmxa contain objects outside of ocamldoc


Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker