Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting GNU-style error messages #6518

Closed
vicuna opened this issue Aug 21, 2014 · 4 comments
Closed

Consider supporting GNU-style error messages #6518

vicuna opened this issue Aug 21, 2014 · 4 comments

Comments

@vicuna
Copy link

vicuna commented Aug 21, 2014

Original bug ID: 6518
Reporter: @gasche
Status: acknowledged (set by @gasche on 2014-08-21T05:47:51Z)
Resolution: open
Priority: normal
Severity: feature
Category: compiler driver
Duplicate of: #5070
Related to: #6087
Monitored by: @yakobowski

Bug description

In PR #6087 Daniel Bünzli requested the use of the more standard GNU-style error messages, which have the advantage of being recognized by tools without specific configuration -- while the error-message-regexp that Emacs uses to match OCaml error messages recently changed and could require upstream change as well.

Additional information

(Note that even if a compiler-wide switch happens, ocamlbuild will need to be changed separately as it embeds its own error-location printing routines in ocamlbuild/loc.ml)

@mshinwell
Copy link
Contributor

In the face of #8541 I don't think this needs to remain open.

@gasche gasche reopened this Apr 17, 2020
@mshinwell
Copy link
Contributor

@gasche I didn't see any reason for this to remain open having looked at the discussion in #8541. What value do you see in reopening it?

@gasche
Copy link
Member

gasche commented Apr 17, 2020

The two issues/PRs are discussing fairly different things. This one suggests using the standard gnu-style locations that are a cryptic foo.ml:23-25:13-68 or something like that, and that (apparently?) many tools support out of the box. #8541 is about changing slightly the custom format we used for OCaml (because it was broken in the multiline case), but in fact the discussion there shows that most editors had to change their custom-made regex for OCaml error messages -- whereas presumably using the "standard" mode would have been supported out of the box, witho requiring having or modifying OCaml-specific logic.

@github-actions
Copy link

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants