Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

double warning on (&) and (or) #6522

Closed
vicuna opened this issue Aug 28, 2014 · 2 comments
Closed

double warning on (&) and (or) #6522

vicuna opened this issue Aug 28, 2014 · 2 comments
Labels
bug
Milestone
4.02.1

Comments

@vicuna
Copy link

vicuna commented Aug 28, 2014

Original bug ID: 6522
Reporter: @damiendoligez
Status: closed (set by @damiendoligez on 2014-09-22T19:34:36Z)
Resolution: fixed
Priority: normal
Severity: tweak
Version: 4.02.0+dev
Target version: 4.02.1+dev
Fixed in version: 4.02.1+dev
Category: ~DO NOT USE (was: OCaml general)

Bug description

Now that (&) and (or) are marked obsolete in the stdlib, we get two warnings about each.
We should remove the ad-hoc code that warns about them, and let the generic one do its job.

Steps to reproduce

$ ocaml
OCaml version 4.02.0+dev16-2014-08-21

true & true;;

Warning 3: deprecated: Pervasives.&
Warning 3: deprecated: operator (&); you should use (&&) instead

  • : bool = true
@vicuna
Copy link
Author

vicuna commented Aug 28, 2014

Comment author: @alainfrisch

Note that the @@deprecated attribute can take a string argument which will be displayed along with the warning message. This allows us to give the same information as the previous ad hoc code.

@vicuna
Copy link
Author

vicuna commented Sep 14, 2014

Comment author: @damiendoligez

fixed in 4.02 branch (commit 15225)

also added hints to most deprecated stdlib functions

@vicuna vicuna closed this as completed Sep 22, 2014
@vicuna vicuna added this to the 4.02.1 milestone Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.02.1
Development

No branches or pull requests
1 participant
@vicuna