Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdlib/gc.mli and byterun/config.h disagree on the default size of the minor heap #6540

Closed
vicuna opened this issue Sep 3, 2014 · 4 comments

Comments

@vicuna
Copy link

vicuna commented Sep 3, 2014

Original bug ID: 6540
Reporter: drichman
Assigned to: @diml
Status: closed (set by @xavierleroy on 2016-12-07T10:34:41Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.02.0+beta1 / +rc1
Fixed in version: 4.02.1+dev
Category: documentation

Bug description

byterun/config.h

/* Default size of the minor zone. (words)  */
#define Minor_heap_def 262144

doesn't match stdlib/gc.mli

{ mutable minor_heap_size : int;
(** The size (in words) of the minor heap. Changing
this parameter will trigger a minor collection. Default: 32k. *)

@vicuna
Copy link
Author

vicuna commented Sep 3, 2014

Comment author: drichman

Ditto

/* Default maximum size of the stack (words). */
#define Max_stack_def (1024 * 1024)

vs

mutable stack_limit : int;
(** The maximum size of the stack (in words).  This is only
    relevant to the byte-code runtime, as the native code runtime
    uses the operating system's stack.  Default: 256k. *)

(do you want a separate issue for this?)

@vicuna
Copy link
Author

vicuna commented Sep 3, 2014

Comment author: drichman

Proposed patch at #95

Thanks,
Daniel

@vicuna
Copy link
Author

vicuna commented Sep 3, 2014

Comment author: @diml

Thanks, I applied the patch. Revision 15185.

@vicuna
Copy link
Author

vicuna commented Sep 11, 2014

Comment author: @mshinwell

Also fixed for 4.02.1

@vicuna vicuna closed this as completed Dec 7, 2016
@vicuna vicuna assigned ghost Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant