Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Int64.bits_of_float and Int64.float_of_bits %-primitives #6551

Closed
vicuna opened this issue Sep 10, 2014 · 1 comment
Closed

Make Int64.bits_of_float and Int64.float_of_bits %-primitives #6551

vicuna opened this issue Sep 10, 2014 · 1 comment

Comments

@vicuna
Copy link

vicuna commented Sep 10, 2014

Original bug ID: 6551
Reporter: @diml
Assigned to: @diml
Status: closed (set by @xavierleroy on 2017-02-16T14:14:36Z)
Resolution: not a bug
Priority: normal
Severity: minor
Version: 4.02.0
Target version: undecided
Fixed in version: 4.03.0+dev / +beta1
Category: middle end (typedtree to clambda)
Monitored by: @gasche

Bug description

These function are currently defined as C calls. They are used in bin_prot to read/write floats and this forces extra allocations since the C call prevent unboxing.

The bin_prot functions to read/write floats are used a lot so this has a non-negligible impact on performances.

@vicuna
Copy link
Author

vicuna commented Nov 5, 2015

Comment author: @diml

These functions are still C calls but are not forcing to box anymore following this:

#277

@vicuna vicuna closed this as completed Feb 16, 2017
@vicuna vicuna assigned ghost Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant