You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the bin_annot flag is only effective when compiling. It should be enabled when packing, too.
Patch is in "Additional Information".
Additional information
--- ocamlbuild/ocaml_specific.ml.orig Mon Oct 6 06:42:27 2014
+++ ocamlbuild/ocaml_specific.ml Mon Oct 6 06:42:31 2014
@@ -669,6 +669,7 @@ flag ["ocaml"; "link"; "byte"; "output_obj"] (A"-outpu
flag ["ocaml"; "dtypes"; "compile"] (A "-dtypes");;
flag ["ocaml"; "annot"; "compile"] (A "-annot");;
flag ["ocaml"; "bin_annot"; "compile"] (A "-bin-annot");;
+flag ["ocaml"; "bin_annot"; "pack"] (A "-bin-annot");;
flag ["ocaml"; "safe_string"; "compile"] (A "-safe-string");;
flag ["ocaml"; "safe_string"; "infer_interface"] (A "-safe-string");;
flag ["ocaml"; "unsafe_string"; "compile"] (A "-unsafe-string");;
The text was updated successfully, but these errors were encountered:
I tried to review other flags for related mistakes when I applied the patch, but I'll admit that I'm a bit lost at the semantics of some of the flags when packing. It cannot hurt to apply defensively, so I'll add "annot" just in case; feel free to suggest any other likely candidate.
Original bug ID: 6599
Reporter: madroach
Assigned to: @gasche
Status: closed (set by @xavierleroy on 2016-12-07T10:36:48Z)
Resolution: fixed
Priority: normal
Severity: minor
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues
Monitored by: @hcarty
Bug description
the bin_annot flag is only effective when compiling. It should be enabled when packing, too.
Patch is in "Additional Information".
Additional information
--- ocamlbuild/ocaml_specific.ml.orig Mon Oct 6 06:42:27 2014
+++ ocamlbuild/ocaml_specific.ml Mon Oct 6 06:42:31 2014
@@ -669,6 +669,7 @@ flag ["ocaml"; "link"; "byte"; "output_obj"] (A"-outpu
flag ["ocaml"; "dtypes"; "compile"] (A "-dtypes");;
flag ["ocaml"; "annot"; "compile"] (A "-annot");;
flag ["ocaml"; "bin_annot"; "compile"] (A "-bin-annot");;
+flag ["ocaml"; "bin_annot"; "pack"] (A "-bin-annot");;
flag ["ocaml"; "safe_string"; "compile"] (A "-safe-string");;
flag ["ocaml"; "safe_string"; "infer_interface"] (A "-safe-string");;
flag ["ocaml"; "unsafe_string"; "compile"] (A "-unsafe-string");;
The text was updated successfully, but these errors were encountered: