Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Toploop.phrase #6609

Closed
vicuna opened this issue Oct 11, 2014 · 4 comments
Closed

Export Toploop.phrase #6609

vicuna opened this issue Oct 11, 2014 · 4 comments
Assignees
Labels

Comments

@vicuna
Copy link

vicuna commented Oct 11, 2014

Original bug ID: 6609
Reporter: @whitequark
Assigned to: @alainfrisch
Status: closed (set by @alainfrisch on 2014-10-13T14:56:05Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.02.1+dev
Fixed in version: 4.02.1+dev
Category: ~DO NOT USE (was: OCaml general)
Monitored by: @gasche @hcarty

Bug description

Currently, there is no way to evaluate a toplevel phrase while engaging ppx rewriters and without loading the compiler-libs interfaces. This is required in order to allow ocamlfind to communicate with ppx rewriters as described in #6582.

@vicuna
Copy link
Author

vicuna commented Oct 11, 2014

Comment author: @whitequark

The reason I cannot use Pparse from findlib directly is that it requires compiler-libs. If I just try to use it without first requiring compiler-libs, the toplevel says:
Exception: Symtable.Error _.

Anyway, preprocess_phrase should have been available since the start.

I've sent a PR that fixes this problem. It renames the formerly module-private function, as the new name is much better for a public API, but has no semantic change. It should be safe to merge into 4.02.1.

#105

@vicuna
Copy link
Author

vicuna commented Oct 12, 2014

Comment author: @alainfrisch

I'm in favor of integrating into 4.02.1, if it's not too late.

@vicuna
Copy link
Author

vicuna commented Oct 13, 2014

Comment author: @alainfrisch

Committed to trunk (15528) and 4.02 (15529).

@vicuna
Copy link
Author

vicuna commented Oct 13, 2014

Comment author: @alainfrisch

Approved by our release manager for inclusion in 4.02.1.

@vicuna vicuna closed this as completed Oct 13, 2014
@vicuna vicuna added the bug label Mar 20, 2019
avsm pushed a commit to avsm/ocaml that referenced this issue Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants