Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual example does not initialize compare_ext field #6854

Closed
vicuna opened this issue Apr 28, 2015 · 1 comment
Closed

Manual example does not initialize compare_ext field #6854

vicuna opened this issue Apr 28, 2015 · 1 comment

Comments

@vicuna
Copy link

vicuna commented Apr 28, 2015

Original bug ID: 6854
Reporter: @lpw25
Status: closed (set by @xavierleroy on 2017-02-16T14:18:27Z)
Resolution: fixed
Priority: normal
Severity: minor
Target version: 4.03.0+dev / +beta1
Fixed in version: 4.03.0+dev / +beta1
Category: documentation
Tags: junior_job
Monitored by: @gasche @hcarty

Bug description

The example in:

http://caml.inria.fr/pub/docs/manual-ocaml-4.00/manual033.html#toc147

initializes a struct custom_operations but does not include a value for the compare_ext field.

Since custom_compare_ext_default is NULL this is not technically a bug, but it seems better to include it (and it will cause warnings in gcc if you use -Wextra).

@vicuna
Copy link
Author

vicuna commented Dec 6, 2015

Comment author: @xavierleroy

Fixed in commit [trunk 9f7f3ce]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant