Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile Warnings with MSVC #6858

Closed
vicuna opened this issue May 6, 2015 · 1 comment
Closed

Compile Warnings with MSVC #6858

vicuna opened this issue May 6, 2015 · 1 comment

Comments

@vicuna
Copy link

vicuna commented May 6, 2015

Original bug ID: 6858
Reporter: schommer
Status: closed (set by @xavierleroy on 2017-02-16T14:18:28Z)
Resolution: fixed
Priority: normal
Severity: minor
OS: Windows
Version: 4.02.0
Target version: 4.03.0+dev / +beta1
Fixed in version: 4.03.0+dev / +beta1
Category: platform support (windows, cross-compilation, etc)
Monitored by: @jmeber

Bug description

MSVC produces compile warning when using the caml headers for C stubs about functions with missing return and redefined macros, for example:
unixsupport.c(174) : warning C4005: 'EWOULDBLOCK' : macro redefinition
or
asmrun\floats.c(153) : warning C4715: 'caml_float_of_string' : not all control paths return a value

The reason is missing define guards in otherlibs/win32unix/unixsupport.c and the fact that the noreturn macro only defined with gcc.
I already submitted a pull request at the github mirror which add define guards for the macros and a working noreturn macro for MSVC 2008 and later.

Additional information

The pull request containing the patch:
#165

@vicuna
Copy link
Author

vicuna commented Dec 6, 2015

Comment author: @xavierleroy

#165 was merged, these issues should now be fixed.

@vicuna vicuna closed this as completed Feb 16, 2017
@vicuna vicuna added this to the 4.03.0 milestone Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant