You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Original bug ID: 6858 Reporter: schommer Status: closed (set by @xavierleroy on 2017-02-16T14:18:28Z) Resolution: fixed Priority: normal Severity: minor OS: Windows Version: 4.02.0 Target version: 4.03.0+dev / +beta1 Fixed in version: 4.03.0+dev / +beta1 Category: platform support (windows, cross-compilation, etc) Monitored by:@jmeber
Bug description
MSVC produces compile warning when using the caml headers for C stubs about functions with missing return and redefined macros, for example:
unixsupport.c(174) : warning C4005: 'EWOULDBLOCK' : macro redefinition
or
asmrun\floats.c(153) : warning C4715: 'caml_float_of_string' : not all control paths return a value
The reason is missing define guards in otherlibs/win32unix/unixsupport.c and the fact that the noreturn macro only defined with gcc.
I already submitted a pull request at the github mirror which add define guards for the macros and a working noreturn macro for MSVC 2008 and later.
Original bug ID: 6858
Reporter: schommer
Status: closed (set by @xavierleroy on 2017-02-16T14:18:28Z)
Resolution: fixed
Priority: normal
Severity: minor
OS: Windows
Version: 4.02.0
Target version: 4.03.0+dev / +beta1
Fixed in version: 4.03.0+dev / +beta1
Category: platform support (windows, cross-compilation, etc)
Monitored by: @jmeber
Bug description
MSVC produces compile warning when using the caml headers for C stubs about functions with missing return and redefined macros, for example:
unixsupport.c(174) : warning C4005: 'EWOULDBLOCK' : macro redefinition
or
asmrun\floats.c(153) : warning C4715: 'caml_float_of_string' : not all control paths return a value
The reason is missing define guards in otherlibs/win32unix/unixsupport.c and the fact that the noreturn macro only defined with gcc.
I already submitted a pull request at the github mirror which add define guards for the macros and a working noreturn macro for MSVC 2008 and later.
Additional information
The pull request containing the patch:
#165
The text was updated successfully, but these errors were encountered: