Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of #ml from config/Makefile #6860

Closed
vicuna opened this issue May 7, 2015 · 4 comments
Closed

Get rid of #ml from config/Makefile #6860

vicuna opened this issue May 7, 2015 · 4 comments

Comments

@vicuna
Copy link

vicuna commented May 7, 2015

Original bug ID: 6860
Reporter: @whitequark
Status: acknowledged (set by @damiendoligez on 2015-05-08T21:08:37Z)
Resolution: open
Priority: normal
Severity: feature
Version: 4.02.2+dev / +rc1
Target version: undecided
Category: configure and build/install
Monitored by: @gasche

Bug description

Currently, #ml in config/Makefile require using sed1 in configuration scripts instead of variables2. It's only used for ocamlmklib and it should not be hard to make it depend on the Config module.

@vicuna
Copy link
Author

vicuna commented May 8, 2015

Comment author: @damiendoligez

As far as I know, this #ml annotation is for ocamlbuild. What I'm not sure is if it's still used or if it was only used by the ocamlbuild-based build of ocaml itself. @gasche?

@vicuna
Copy link
Author

vicuna commented May 9, 2015

Comment author: @whitequark

I have specifically looked at the #ml annotation when I was doing the Android port and it's only used for ocamlmklib. ocamlmklib was a part of ocamlbuild some time ago, but now it seems to be a standalone tool.

@vicuna
Copy link
Author

vicuna commented May 15, 2015

Comment author: @alainfrisch

ocamlmklib was a part of ocamlbuild some time ago

I don't think so. ocamlmklib was there a long time before ocamlbuild was born.

@stedolan
Copy link
Contributor

This was fixed by b799715.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants