Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linking with flexlink fails when passing arguments by response file #6864

Closed
vicuna opened this issue May 11, 2015 · 4 comments
Closed

linking with flexlink fails when passing arguments by response file #6864

vicuna opened this issue May 11, 2015 · 4 comments

Comments

@vicuna
Copy link

vicuna commented May 11, 2015

Original bug ID: 6864
Reporter: gideon
Assigned to: @damiendoligez
Status: assigned (set by @damiendoligez on 2015-05-12T16:28:45Z)
Resolution: open
Priority: low
Severity: minor
Platform: cygwin, msvs64
OS: windows
OS Version: 7
Category: platform support (windows, cross-compilation, etc)
Tags: patch
Related to: #5312

Bug description

On windows we are linking the llvm libraries with an ocaml leading to a rather large command on the commandline.

Consequently ocaml decides to call flexdll using a response file, that is, it passes arguments to flexlink by file to shorten the command. Unfortunately flexlink seems to accept only files in the response file but ocaml happily passes anything in the response file, e.g., options from -cclib or a path from -I which are, so it seems, interpreted as filenames by flexlink. I also have the impression they are not escaped/translated correctly, but that is rather difficult to judge with paths in cygwin.

File attachments

@vicuna
Copy link
Author

vicuna commented May 11, 2015

Comment author: aha

I've reported the same issue month ago here: https://code.google.com/p/flexdll/issues/detail?id=4
The bug report contains a small patch to avoid this problem.

@vicuna
Copy link
Author

vicuna commented May 11, 2015

Comment author: @damiendoligez

Copied the patch here for reference.

@vicuna
Copy link
Author

vicuna commented May 3, 2016

Comment author: @alainfrisch

A partial solution has been applied (to allow options in addition to filenames in response file), not the part related to better unquoting.

See ocaml/flexdll#18

@github-actions
Copy link

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants