Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incomplete fix of PR6797; ocamlbuild not taken into account #6929

Closed
vicuna opened this issue Jul 12, 2015 · 3 comments
Closed

incomplete fix of PR6797; ocamlbuild not taken into account #6929

vicuna opened this issue Jul 12, 2015 · 3 comments

Comments

@vicuna
Copy link

vicuna commented Jul 12, 2015

Original bug ID: 6929
Reporter: @whitequark
Assigned to: @whitequark
Status: resolved (set by @damiendoligez on 2017-02-24T12:00:26Z)
Resolution: suspended
Priority: normal
Severity: minor
Version: 4.02.2
Target version: later
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues
Tags: patch
Related to: #6797
Monitored by: @gasche

Bug description

The -output-complete-obj flag works great, but ocamlbuild x.native.o still uses the -output-obj one, and it's still unusable for modules which come with autolink flags.

File attachments

@vicuna
Copy link
Author

vicuna commented Jul 12, 2015

Comment author: @whitequark

I have attached a suggested patch. Anyone looking to fix this before a release can use the following myocamlbuild.ml rules:

dispatch (function
| After_rules ->
flag ["ocaml"; "link"; "native"; "output_obj"] (A"-output-complete-obj");
flag ["ocaml"; "link"; "byte"; "output_obj"] (A"-output-complete-obj")
| _ -> ())

@vicuna
Copy link
Author

vicuna commented Jul 19, 2015

Comment author: @whitequark

Update: this does not actually work, for much of the same reasons that are described in #6927#c14212. I believe the proper fix would be to use the -force_load flag in the compiler driver in the appropriate places to ensure that the entire camlrun/asmrun library is included.

@vicuna
Copy link
Author

vicuna commented Feb 24, 2017

Comment author: @damiendoligez

ocamlbuild is now an independent project that lives on GitHub.
PR transferred to ocaml/ocamlbuild#148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant