Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not pass -g to cl on Windows #7078

Closed
vicuna opened this issue Dec 7, 2015 · 2 comments
Closed

Do not pass -g to cl on Windows #7078

vicuna opened this issue Dec 7, 2015 · 2 comments
Assignees
@alainfrisch
Labels
bug platform-support

Comments

@vicuna
Copy link

vicuna commented Dec 7, 2015

Original bug ID: 7078
Reporter: @Chris00
Assigned to: @alainfrisch
Status: closed (set by @xavierleroy on 2017-09-24T15:31:44Z)
Resolution: fixed
Priority: normal
Severity: minor
Platform: amd64
OS: Debian Linux
OS Version: kernel 4.1.13
Version: 4.02.3
Fixed in version: 4.03.0+dev / +beta1
Category: platform support (windows, cross-compilation, etc)

Bug description

On Windows (Win64), the -g option should be translated to the corresponding option of cl instead of being passed directly:
https://ci.appveyor.com/project/Chris00/ocaml-mindstorm/build/1.0.122#L335
@vicuna
Copy link
Author

vicuna commented Jan 5, 2016

Comment author: @alainfrisch

Would people actually benefit from passing '/Zi', for instance? Or should we just remove the -g flag when calling cl?

@vicuna
Copy link
Author

vicuna commented Jan 7, 2016

Comment author: @alainfrisch

Commit 2264004 on trunk: simply drop '-g', also use use '/Fo' instead of '-o' (which also produces a warning). If something think passing /Zi would be useful, please speak up!

@vicuna vicuna closed this as completed Sep 24, 2017
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alainfrisch alainfrisch

Labels
bug platform-support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alainfrisch @vicuna