Comment author: @sliquister

Presumably Typemod.type_toplevel_phrase should call Typetexp.emit_external_warnings.structure, like Typemod.type_implementation and Typemod.type_interface do.

Comment author: @diml

Indeed, I committed the fix in trunk (87f92ab)

Comment author: @diml

Thinking more about this, using an AST mapper here is not perfect as you can't disable the warning with [@@@ocaml.warning "-22"].

Comment author: @alainfrisch

using an AST mapper here is not perfect as you can't disable the warning with [@@@ocaml.warning "-22"].

Indeed, and here is what the comment in the code says:

let emit_external_warnings =
  (* Note: this is run as a preliminary pass when type-checking an
     interface or implementation.  This allows to cover all kinds of
     attributes, but the drawback is that it doesn't take local
     configuration of warnings (with '@@warning'/'@@warnerror'
     attributes) into account.  We should rather check for
     'ppwarning' attributes during the actual type-checking, making
     sure to cover all contexts (easier and more ugly alternative:
     duplicate here the logic which control warnings locally). *)
...