Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamldep behaviour regarding extension points is not documented #7117

Closed
vicuna opened this issue Jan 6, 2016 · 6 comments
Closed

ocamldep behaviour regarding extension points is not documented #7117

vicuna opened this issue Jan 6, 2016 · 6 comments

Comments

@vicuna
Copy link

vicuna commented Jan 6, 2016

Original bug ID: 7117
Reporter: michi
Status: confirmed (set by @damiendoligez on 2016-02-08T11:35:48Z)
Resolution: open
Priority: normal
Severity: minor
Version: 4.02.3
Category: tools (ocaml{lex,yacc,dep,debug,...})

Bug description

In my project using extension points, ocamldep is unable to generate appropriate dependencies when code contain extension points. I remarked that, when not told to use the necessary PPX filters, ocamldep skips expressions within an extension point.

This is perfectly sound but this is neither described in the man page (4.02.3) nor on the website[1], but it should be described in both.

Also, at the time of writing, the content of the page [1] describing the use of ocamldep is out of sync with the man page and does not mention the possible use of PPX filters.

[1] http://caml.inria.fr/pub/docs/manual-ocaml/depend.html

@vicuna
Copy link
Author

vicuna commented Jan 6, 2016

Comment author: @alainfrisch

I think the behavior has changed recently and ocamldep now rejects extension points (usually representing forgotten ppx options).

@vicuna
Copy link
Author

vicuna commented Jan 6, 2016

Comment author: michi

Thanks Alain for your quick reply. Rejecting extension points in this case is probably the right behaviour,
as missing PPX filters signal an ill-configured project.

See also: foretspaisibles/bsdowl#219 for support of OCamldep + PPX in BSD Owl

@vicuna
Copy link
Author

vicuna commented Jan 6, 2016

Comment author: @diml

ocamldep still ignores extension points in trunk. The recent change was to make ocamldep interpret [%ocaml.error]

@vicuna
Copy link
Author

vicuna commented Jan 6, 2016

Comment author: @alainfrisch

Ah yes, indeed, sorry. If everyone agree one should reject unknown extension in ocamldep, perhaps it's a good time to do it.

@vicuna
Copy link
Author

vicuna commented Jan 6, 2016

Comment author: @diml

I agree that ocamldep should reject unknown extensions

@vicuna vicuna added the tools label Mar 14, 2019
@nojb nojb added the ocamldep label Mar 16, 2019
@vicuna vicuna added the bug label Mar 20, 2019
@github-actions
Copy link

github-actions bot commented May 9, 2020

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants