Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for O_DIRECT #7155

Closed
vicuna opened this issue Feb 21, 2016 · 5 comments
Closed

support for O_DIRECT #7155

vicuna opened this issue Feb 21, 2016 · 5 comments

Comments

@vicuna
Copy link

vicuna commented Feb 21, 2016

Original bug ID: 7155
Reporter: toolslive
Status: acknowledged (set by @xavierleroy on 2016-06-29T07:46:50Z)
Resolution: open
Priority: normal
Severity: feature
Version: 4.02.3
Category: standard library
Monitored by: domsj @diml

Bug description

The open_flag type in the Unix module lacks O_DIRECT.

@vicuna
Copy link
Author

vicuna commented Feb 22, 2016

Comment author: toolslive

would you be interested in a patch ?

@vicuna
Copy link
Author

vicuna commented Jun 29, 2016

Comment author: @xavierleroy

O_DIRECT is Linux-specific, as far as I can see. Until now we tried hard to support only flags that are standardized e.g. in the Single Unix Specification. Is there a strong use case for O_DIRECT that would justify an exception to this rule?

@vicuna
Copy link
Author

vicuna commented Dec 6, 2016

Comment author: @alainfrisch

Note there is already O_SHARE_DELETE, which exists only under Windows.

But again, we'd need at least on concrete use case to consider the addition.

@vicuna
Copy link
Author

vicuna commented Jan 1, 2017

Comment author: toolslive

The reason is that sometimes you want to write (or read) without the linux page cache caching the data. This because you know you will not be needing that data anymore in the foreseeable future. The alternative is to explain this to the page cache via fadvise.

In the absence of the call, we took the fadvise route, which is simpler than to create an alternative open call (or to maintain an ocaml fork)

@github-actions
Copy link

github-actions bot commented May 9, 2020

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant