Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlmklib should respect OCAMLPARAM #7219

Closed
vicuna opened this issue Apr 11, 2016 · 6 comments
Closed

ocamlmklib should respect OCAMLPARAM #7219

vicuna opened this issue Apr 11, 2016 · 6 comments

Comments

@vicuna
Copy link

vicuna commented Apr 11, 2016

Original bug ID: 7219
Reporter: @whitequark
Status: acknowledged (set by @gasche on 2016-04-11T20:29:34Z)
Resolution: open
Priority: normal
Severity: feature
Version: 4.02.3
Category: tools (ocaml{lex,yacc,dep,debug,...})
Tags: junior_job
Monitored by: @gasche

Bug description

... specifically, at least ccopts and cclib, but probably other variables too.

This makes it very annoying to pass -I/-L paths to native dependencies through e.g. OASIS.

@vicuna
Copy link
Author

vicuna commented Apr 11, 2016

Comment author: @gasche

I think this is a fine feature suggestion, but the implementation is a bit tedious because ocamlmklib currently implements its own bare-metal argument handling logic, sensibly simpler than the rest of the compiler. That means you cannot just call the compiler OCAMLPARAM-parsing function and be done with it; the best way to go is probably to reimplement the command-line argument parsing logic of ocamlmklib.

Would anyone be interested in proposing a patch to do this?

@vicuna
Copy link
Author

vicuna commented Apr 11, 2016

Comment author: @whitequark

What I did for now is implemented an OCAMLMKLIBPARAM (https://github.com/whitequark/opam-cross-android/blob/master/packages/ocaml-android32.4.02.3/files/patches/ocamlmklib.patch). But this is rather suboptimal.

@vicuna
Copy link
Author

vicuna commented Apr 11, 2016

Comment author: @whitequark

FWIW ocamlmklib's options are sufficiently different from ocamlc's that I'm not sure if it even makes sense to reuse Compenv.read_OCAMLPARAM; what I would do is to call Compenv.parse_args, and then manually reimplement the parameters relevant for ocamlmklib, of which there are very few.

@github-actions
Copy link

github-actions bot commented May 9, 2020

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

@github-actions github-actions bot added the Stale label May 9, 2020
@whitequark
Copy link
Member

With the broad migration to dune this issue is much less relevant and I suspect it can be simply ignored until the need for ocamlmklib goes away.

@xavierleroy
Copy link
Contributor

That makes sense. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants