Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamldep: order of -open options #7248

Closed
vicuna opened this issue May 6, 2016 · 2 comments
Closed

ocamldep: order of -open options #7248

vicuna opened this issue May 6, 2016 · 2 comments
Assignees

Comments

@vicuna
Copy link

vicuna commented May 6, 2016

Original bug ID: 7248
Reporter: antron
Assigned to: @gasche
Status: closed (set by @xavierleroy on 2017-09-24T15:32:52Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.03.0
Fixed in version: 4.04.0 +dev / +beta1 / +beta2
Category: tools (ocaml{lex,yacc,dep,debug,...})

Bug description

It seems ocamldep has the order of -open options backwards.

Steps to reproduce

namespaces_map.ml:

module Namespace =
struct
module Bar = Namespace__bar
module Foo = Namespace__foo
end
module Main = Main

foo.ml:

let a = Foo.a

$ ocamldep -modules -map namespaces_map.ml -open Namespaces_map -open Namespace foo.ml
foo.ml: Foo Namespace Namespaces_map

$ ocamldep -modules -map namespaces_map.ml -open Namespace -open Namespaces_map foo.ml
foo.ml: Namespace__foo Namespaces_map

I would expect the outputs to be interchanged. For comparison:

$ ocamlc -open Namespaces_map -open Namespace foo.ml
(ok)

$ ocamlc -open Namespace -open Namespaces_map foo.ml
File "command line", line 1:
Error: Unbound module Namespace

@vicuna
Copy link
Author

vicuna commented May 6, 2016

Comment author: @gasche

Fixed in trunk ( cc69cbf ), thanks for the report.

@vicuna
Copy link
Author

vicuna commented May 6, 2016

Comment author: antron

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants