Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert_failure typing/ctype.ml:1390:10 #7324

Closed
vicuna opened this issue Aug 11, 2016 · 4 comments
Closed

Assert_failure typing/ctype.ml:1390:10 #7324

vicuna opened this issue Aug 11, 2016 · 4 comments
Assignees

Comments

@vicuna
Copy link

vicuna commented Aug 11, 2016

Original bug ID: 7324
Reporter: jmcarthur
Assigned to: @garrigue
Status: resolved (set by @garrigue on 2016-08-16T01:46:22Z)
Resolution: fixed
Priority: normal
Severity: crash
Fixed in version: 4.04.0 +dev / +beta1 / +beta2
Category: typing
Has duplicate: #7379
Monitored by: @gasche @yallop

Bug description

OCaml 4.03.0 type checker dies with an assert failure when given the expression I included in the "Steps To Reproduce" section of this issue.

Steps to reproduce

module rec T : sig type t = T.t end = T

@vicuna
Copy link
Author

vicuna commented Aug 16, 2016

Comment author: @garrigue

Fixed in 4.04 by commit e17dce1.

This assertion was not really needed, and invalidated by recursive modules (the cyclicity test is done later).

@vicuna vicuna closed this as completed Aug 16, 2016
@vicuna
Copy link
Author

vicuna commented Aug 17, 2016

Comment author: @gasche

There is another failure in opam-builder that looks related in the "sanlock" package:

http://opam.ocamlpro.com/builder/html/sanlock/sanlock.0.0.9/b5c253e9b51727accb888b62b976bd71

I will be able to know for sure whether the fix to this MPR also fixes the sanlock issue when opam-builder gets updated with a more recent version of 4.04 (for now it's running the first beta without the present fix).

@vicuna
Copy link
Author

vicuna commented Aug 18, 2016

Comment author: @garrigue

What makes you think it is related? I only see a Not_found exception,

@vicuna
Copy link
Author

vicuna commented Aug 18, 2016

Comment author: @gasche

Right, it's more likely to be an independent bug, I should file a separate report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants