Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -Werror from installed Makefile.config #7327

Closed
vicuna opened this issue Aug 16, 2016 · 3 comments
Closed

Remove -Werror from installed Makefile.config #7327

vicuna opened this issue Aug 16, 2016 · 3 comments
Milestone

Comments

@vicuna
Copy link

vicuna commented Aug 16, 2016

Original bug ID: 7327
Reporter: @damiendoligez
Status: resolved (set by @xavierleroy on 2016-12-05T08:59:27Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.05.0 +dev/beta1/beta2/beta3/rc1
Target version: 4.05.0 +dev/beta1/beta2/beta3/rc1
Fixed in version: 4.05.0 +dev/beta1/beta2/beta3/rc1
Category: runtime system and C interface
Monitored by: @gasche

Bug description

On Unix, Makefile.config contains -Werror in its BYTECCCOMPOPTS and NATIVECCCOMPOPTS variables. This is equivalent to -warn-error A and it's bad.

See garrigue/labltk#2 for an example of why it's bad: a new warning in gcc breaks labltk for no good reason.

@vicuna
Copy link
Author

vicuna commented Aug 16, 2016

Comment author: @gasche

Couldn't we do this in 4.04 already?

@vicuna
Copy link
Author

vicuna commented Aug 16, 2016

Comment author: @xavierleroy

'-Werror' is set only if it's a development version of OCaml. It is not set if it is a release version. Cf. file configure, lines 315-318.

I find it important that the C parts of the core OCaml system are compiled with -Werror during development. Otherwise we just ignore gcc's warnings.

@vicuna
Copy link
Author

vicuna commented Dec 5, 2016

Comment author: @xavierleroy

I think this was fixed by Sebastien Hinderer in commit 3e81da2. Reopen if the problem is still here.

@vicuna vicuna closed this as completed Dec 5, 2016
@vicuna vicuna added the stdlib label Mar 14, 2019
@vicuna vicuna added this to the 4.05.0 milestone Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant