Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-dsource output for local open module Patterns #7329

Closed
vicuna opened this issue Aug 19, 2016 · 2 comments
Closed

-dsource output for local open module Patterns #7329

vicuna opened this issue Aug 19, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@vicuna
Copy link

vicuna commented Aug 19, 2016

Original bug ID: 7329
Reporter: leonidr
Assigned to: @gasche
Status: closed (set by @xavierleroy on 2017-09-24T15:33:23Z)
Resolution: fixed
Priority: low
Severity: minor
Target version: 4.04.0 +dev / +beta1 / +beta2
Fixed in version: 4.04.0 +dev / +beta1 / +beta2
Category: ~DO NOT USE (was: OCaml general)

Bug description

-dsource doesn't give correct output for local open modules.

Steps to reproduce

$ cat source_me.ml
module M = struct
type t = Foo | Bar
end

let () =
let M.(s) = M.(Foo) in
()
$ ocamlc -dsource source_me.ml
module M = struct type t =
| Foo
| Bar end
let () =
let (((((((...(((Fatal error: exception Stack overflow

Additional information

  1. This is a 4.04 bug, but that isn't in the dropdown, please reassign when ready.
  2. I know that -dsource is undocumented and unsupported, but some tools, such as bisect_ppx, rely upon it for testing.
@vicuna
Copy link
Author

vicuna commented Aug 20, 2016

Comment author: @Octachron

Thanks for reporting this problem! I have opened a github PR
#773
to fix this issue.

@vicuna
Copy link
Author

vicuna commented Aug 20, 2016

Comment author: @gasche

Fixed using Octachron's patch in 4.04 ( bb95cd3 ) and trunk ( 98472df ). Thanks both for the reporting and quick patching.

(There is no Changes entry for this, which I understand is possible for a bug that only makes sense in the development version and has affected no release yet.)

@vicuna vicuna closed this as completed Sep 24, 2017
@vicuna vicuna added this to the 4.04.0 milestone Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants