New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support on Minix3 #7365
Comments
Comment author: @damiendoligez Looks good in general but I have a few questions:
|
Comment author: pmetras
|
Comment author: pmetras For the last point, here is the result of the ifconfig command: ifconfig/dev/ip: address 10.0.2.15 netmask 255.255.255.0 mtu 1500 |
Comment author: pmetras Typo in previous note: "gcc is not available" should have been "gdb is not available". |
Comment author: @damiendoligez
To build the debug runtime you simply need to give the -with-debug-runtime to configure. It will build and install the debug runtime in addition to the normal one. Your mistake is here: -cc 'clang -DDEBUG' this will try to compile both runtimes with the -DDEBUG option, which fails for the normal runtime. For the loopback thing I don't think it's worth the trouble (and potential breakage) of changing the tests. You should just skip them when the loopback interface is not available (as you do for signal2.ml), have a new variable (HAS_LOOPBACK_ADDRESS) in config/Makefile, and add a few lines to configure to set this variable correctly (Minix -> false, anything else -> true). BTW your usage of ifdef is incorrect. Instead of Do you have a GitHub account? It would be easier to discuss this in a GitHub PR. |
Comment author: @xavierleroy Pushing to "later" as this isn't ready to go in 4.05. I'm not sure this port is something we want to integrate in the core distribution (as opposed to having the Minix people package a modified version of OCaml). At any rate, I object to changing the test suite to work around Minix limitations, and especially ot substituting VMthreads for systhreads, because as #7366 shows the substitution doesn't work. |
There didn't seem to be much enthusiasm for this back in 2017, and there was no response from the author to the latest review comments, so I'm going to close this. If there is demand for Minix support in the future we can always reevaluate. |
Original bug ID: 7365
Reporter: pmetras
Assigned to: @shindere
Status: assigned (set by @damiendoligez on 2017-02-27T15:20:09Z)
Resolution: open
Priority: normal
Severity: feature
Platform: i386
OS: Minix3
OS Version: 3.4.0
Category: platform support (windows, cross-compilation, etc)
Monitored by: @gasche
Bug description
This patch adds support for Minix3 to OCaml distribution.
Since around 1985, Minix has always been an environment for learning and trying system programming, offering a clean and simple Unix-like operating system, originally written by Andrew S. Tanenbaum. Adding OCaml support on that environment helps both Minix and OCaml enthusiasts offering new tools to play with. And a few years ago, the messages passing architecture of Minix was proven sound by a OCaml program...
You can learn more about Minix on http://www.minix3.org.
Additional information
What's in the patch?
File attachments
The text was updated successfully, but these errors were encountered: