Browse thread
How to do this properly with OCaml?
-
Thomas Fischbacher
- Christophe Dehlinger
- Berke Durak
- Michel Quercia
- Eric Cooper
-
Michael Alexander Hamburg
-
Xavier Leroy
- Berke Durak
- Michael Alexander Hamburg
- Thomas Fischbacher
- Alex Baretta
- skaller
- Thomas Fischbacher
-
Xavier Leroy
[
Home
]
[ Index:
by date
|
by threads
]
[ Message by date: previous | next ] [ Message in thread: previous | next ] [ Thread: previous | next ]
[ Message by date: previous | next ] [ Message in thread: previous | next ] [ Thread: previous | next ]
| Date: | -- (:) |
| From: | Xavier Leroy <Xavier.Leroy@i...> |
| Subject: | Re: [Caml-list] How to do this properly with OCaml? |
> I was constructing a binary heap of tuples the other day. After pondering > these options, I just used Obj.magic 0 as the null value in the array. > The heap was in a module, so nothing else could see the array, and I could > prove that the code never accessed the null elements, so the use of > Obj.magic seemed justified. In other terms: " I was walking in the city the other day. I saw a syringe lying on the sidewalk. I stuck the needle in my forearm. That was a classy neighborhood, so the use of the syringe seemed justified. " Sorry for being sarcastic, but I strongly feel that any suggestion to use Obj functions should be avoided on this list. The OCaml compiler performs some type-dependent optimizations that can result in incorrect code (w.r.t. GC invariants) if wrong types are given using Obj.magic. For instance, the following implementation of "magic" arrays will eventually cause the GC to crash: type 'a t = int array let get (a: 'a t) i = (Obj.magic a.(i) : 'a) let set (a: 'a t) i (x: 'a) = a.(i) <- (Obj.magic x : int) while the same code with "string" instead of "int" will not. You don't understand why? Then, don't use Obj.magic. A few years ago, I spent one full day debugging a mysterious crash in code provided by a user, then realized that the problem was exactly the use of Obj.magic outlined above. I then swore to throw away all bug reports whose repro case uses Obj. So, you can break the type system with Obj, but you get to keep the pieces afterwards. Coming back to the initial question, I would first warn against premature optimization: quite possibly the overhead of the "option" solution is negligible. If not, just ask the user to pass an initial value of the heap element type to the "create heap" function. - Xavier Leroy