Version française
Home     About     Download     Resources     Contact us    
Browse thread
va_arg values
[ Home ] [ Index: by date | by threads ]
[ Search: ]

[ Message by date: previous | next ] [ Message in thread: previous | next ] [ Thread: previous | next ]
Date: -- (:)
From: Xavier Leroy <Xavier.Leroy@i...>
Subject: Re: [Caml-list] va_arg values
> value func(value obj, char *method, int n, ...)
> {
>   va_list ap;
>   int i;
>   value *args = calloc(n + 1, sizeof(value));
>   value r;
>
>   args[0] = obj;
>   va_start(ap, n);
>   for (i = 0; i < n; i++)
>     args[i + 1] = va_arg(ap, value);
>   va_end(ap);
>
>   r = caml_callbackN(caml_get_public_method(obj, hash_variant(method)),
>                      n + 1, args);
>   free(args);
>   return r;
> }
>
> Is it an invalid assumption that it is unnecessary to bother with the
> CAMLparam/CAMLlocal stuff since there's nothing to trip the GC?

It's a valid assumption.  The hard rule is that you must register as
root all local variables that need to survive a call to the GC or to a
function that might trigger the GC.  In general it's hard to keep
track of those variables, which is why the OCaml manual advocates
registering everything that has type "value".  But in your case you
cannot, and the code fragment above look safe to me.  (Make sure you
document this in a big comment, though...)  As others pointed out,
you're also relying on the fact that caml_get_public_method
and hash_variant never trigger a GC, which is true now and in the
foreseeable future, but again a big comment is warranted.

> Should probably check calloc for success and maybe throw an exception
> if it failed... Which actually brings me to another quick question: if
> I throw an exception, say caml_failwith("..."), is it necessary to
> still call CAMLreturn after it? Or will the exception cause the
> function to exit?

The latter: the exception triggers something like a longjmp(), causing
immediate return from the C function (and de-registration of the local
roots, if any).

> One last quick question: is the line "args[i + 1] = va_arg(ap, value);"
> above legal? args[] is an array of value and va_arg(ap, value) will
> return a value. So, essentially, it's the same thing as the assignment
> in the following example:
>
> value func(value v1)
> {
>   value v2 = v1;
>   ...
> }
>
> I know values are just pointers so it is syntactically correct, but
> what I'm asking is: is it safe to do? Should I be using some function
> instead to create a copy of the value?

No copying is necessary.

Hope this helps,

- Xavier Leroy