Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong variable in typecore.ml #2468

Closed
vicuna opened this issue May 23, 2000 · 3 comments
Closed

Wrong variable in typecore.ml #2468

vicuna opened this issue May 23, 2000 · 3 comments
Labels

Comments

@vicuna
Copy link

vicuna commented May 23, 2000

Original bug ID: 127
Reporter: administrator
Status: closed
Resolution: fixed
Priority: normal
Severity: minor
Category: ~DO NOT USE (was: OCaml general)

Bug description

Full_Name: Florian Douetteau
Version: 3.00
OS: Linux
Submission from: www-cache.ens.fr (129.199.2.1)

Dans typing/typecore.ml ligne 394 on a :
| Texp_apply(e, None::el) ->
is_nonexpansive e &&
List.for_all (function None -> true | Some exp -> is_nonexpansive e) el

Logiquement, cela devrait être
(...) | Some exp -> is_nonexpansive exp ) (...)

A propos, à quoi sert ce cas particulier ?

@vicuna
Copy link
Author

vicuna commented May 24, 2000

Comment author: administrator

Logiquement, cela devrait etre
(...) | Some exp -> is_nonexpansive exp ) (...)

Bien vu, je corrige.
C'est cool d'avoir des gens qui verifient votre code par derriere!

A propos, a` quoi sert ce cas particulier ?

En mode -labels, quand un argument non-optionel est absent d'une application
mais que ceux qui le suivent sont presents, il est remplace' par None dans
l'arbre syntaxique type'. L'eta-expansion correspondante est effectuee dans
bytecomp.ml. Comme ca va etre eta-expanse', cette application n'a pas
d'effets de bord.

Par example:

List.map [1;2;3]

donne
Texp_apply(<List.map>, [None, Some <[1;2;3]>])
compile'
(let (func/51 (field 10 (global List!)))
(function param/52 (apply func/51 param/52 [0: 1 [0: 2 [0: 3 0a]]])))

Jacques

@vicuna
Copy link
Author

vicuna commented May 24, 2000

Comment author: administrator

Fixed on 2000-05-24 by Jacques

@vicuna vicuna closed this as completed May 24, 2000
@vicuna
Copy link
Author

vicuna commented Jun 5, 2000

Comment author: administrator

Dans typing/typecore.ml ligne 394 on a :
| Texp_apply(e, None::el) ->
is_nonexpansive e &&
List.for_all (function None -> true | Some exp -> is_nonexpansive e) el

Logiquement, cela devrait être
(...) | Some exp -> is_nonexpansive exp ) (...)

C'est exact. J'ai corrigé cela lors d'une "mise au carré" récente de
la fonction is_nonexpansive.

A propos, à quoi sert ce cas particulier ?

J'avoue ne pas savoir!

  • Xavier Leroy

@vicuna vicuna added the bug label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant