Fix new dynlink's initialisation checks #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirm this fixes Coq plugins in both build modes [using -pack and using aliases]. |
|
cc @alainfrisch @chambart @mshinwell : we don't want to wait for too long between the merge of #1063 in trunk and a fix such as included in the present PR, so I think the urgency of this review is a bit higher than the usual. |
|
Ack, I will read this soon. |
lpw25
force-pushed
the
fix-new-dynlink
branch
from
482d930
to
7d57ebc
Compare
|
Rebased |
mshinwell
requested changes
Dec 3, 2018
| executed completely cannot be depended upon by another shared library being | ||
| loaded. *) | ||
| (* Check that a shared library can refer to a module in the main program | ||
| if its already loaded. *) |
There was a problem hiding this comment.
Please clarify what "its" refers to. (And, "its" -> "it's".)
| *) | ||
|
|
||
| (* Check that a module in a shared library can refer to another module | ||
| in the shared library if it is already loaded. *) |
There was a problem hiding this comment.
Same comment as above regarding "it is".
| *) | ||
|
|
||
| (* Check that a shared library that is loaded during the loading of | ||
| another shared libary can refer to modules of that library if they |
There was a problem hiding this comment.
Typo "libary". Also maybe name the libraries "A" and "B" so we can make "that library" precise.
mshinwell
approved these changes
Dec 7, 2018
|
This is OK to merge after the |
lpw25
force-pushed
the
fix-new-dynlink
branch
from
f07e948
to
8c587da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1063 rewrote the various checks when loading shared libraries with dynlink in order to make them sound. However, the checks to ensure that a module is not used before it has been initialised were far too restrictive. For example, a module in a shared library could not refer to another library within the same shared library. This PR fixes that by updating the list of initialised units earlier. This PR also relaxes the "allowed units" check so that it only applies to implementation dependencies not interface dependencies -- which matches the previous behaviour and is necessary to deal with mli-only modules.
I also added a bunch of tests that exercise the various cases.
This PR should hopefully fix MPR#7876 -- although I haven't actually tried it.
This PR is on top of #2175 because that bug was causing problems with the use of packing added by #1063.