Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pa_macro: someone missed this... #2347

Closed
vicuna opened this issue Mar 15, 2004 · 3 comments
Closed

Pa_macro: someone missed this... #2347

vicuna opened this issue Mar 15, 2004 · 3 comments
Labels

Comments

@vicuna
Copy link

vicuna commented Mar 15, 2004

Original bug ID: 2347
Reporter: administrator
Status: closed
Resolution: fixed
Priority: normal
Severity: minor
Category: ~DO NOT USE (was: OCaml general)

Bug description

Hello folks.

I noticed that pa_macro does not support the use of DEFINEd string
constants as constant patterns. There is no reason for this, since a
single line of code suffices to add them in. I'm sending in the modified
pa_macro.ml.

Drop me a line if you plan to use this patch.

Alex

--- pa_macro.ml 2004-03-15 13:13:41.000000000 +0100
+++ pa_macro.originale 2004-03-15 12:12:27.000000000 +0100
@@ -100,7 +100,6 @@
| <:expr< { $list:pel$ } >> ->
let ppl = List.map (fun (p, e) -> (p, loop e)) pel in
<:patt< { $list:ppl$ } >>

  • | <:expr< $str:x$ >> -> <:patt< $str:x$ >>
    | x ->
    Stdpp.raise_with_loc mloc
    (Failure
@vicuna
Copy link
Author

vicuna commented Jun 29, 2004

Comment author: administrator

Hello,

I've added this feature. Thanks,

-- Michel

Hello folks.

I noticed that pa_macro does not support the use of DEFINEd string
constants as constant patterns. There is no reason for this, since a
single line of code suffices to add them in. I'm sending in the modified
pa_macro.ml.

Drop me a line if you plan to use this patch.

Alex

--- pa_macro.ml 2004-03-15 13:13:41.000000000 +0100
+++ pa_macro.originale 2004-03-15 12:12:27.000000000 +0100
@@ -100,7 +100,6 @@
| <:expr< { $list:pel$ } >> ->
let ppl = List.map (fun (p, e) -> (p, loop e)) pel in
<:patt< { $list:ppl$ } >>

  • | <:expr< $str:x$ >> -> <:patt< $str:x$ >>
    | x ->
    Stdpp.raise_with_loc mloc
    (Failure

@vicuna
Copy link
Author

vicuna commented Jun 29, 2004

Comment author: administrator

Fixed by MM, 2004-06-29

@vicuna vicuna closed this as completed Jun 29, 2004
@vicuna
Copy link
Author

vicuna commented Jun 30, 2004

Comment author: administrator

Michel Mauny wrote:

Hello,

I've added this feature. Thanks,

Great. Thanks!

Alex

@vicuna vicuna added the bug label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant