Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camlp4 bug introduced in 3.09.1, working with 3.09.0 #3948

Closed
vicuna opened this issue Jan 5, 2006 · 1 comment
Closed

Camlp4 bug introduced in 3.09.1, working with 3.09.0 #3948

vicuna opened this issue Jan 5, 2006 · 1 comment

Comments

@vicuna
Copy link

vicuna commented Jan 5, 2006

Original bug ID: 3948
Reporter: spiralvoice
Assigned to: @mauny
Status: closed (set by @xavierleroy on 2007-02-21T15:21:21Z)
Resolution: fixed
Priority: normal
Severity: major
Version: 3.09.0
Fixed in version: 3.09.3
Category: -for Camlp4 use https://github.com/ocaml/camlp4/issues

Bug description

New camlp4 fails on this file:

camlp4 pa_o.cmo ./pa_zog.cma pr_o.cmo -impl src/gtk/gui/gui_window_base.zog > src/gtk/gui/gui_window_base.ml
Uncaught exception: Stack_overflow
Uncaught exception: Stack overflow
gmake: *** [src/gtk/gui/gui_window_base.ml] Error 2

Additional information

Reverting
camlp4/etc/pr_o.ml
camlp4/etc/pr_r.ml
to their previous state solves the problem.

The problematic file is part of the MLDonkey project:
http://cvs.savannah.nongnu.org/viewcvs/mldonkey/src/gtk/gui/gui_window_base.zog?rev=1.1&root=mldonkey&view=markup
Maybe some syntax in that file is wrong, help on that is appreciated.

Attached you will find the patch reverting the two files in Ocaml 3.09.1,
with this compiling (./configure --enable-gui=oldgui) of MLDonkey works again.

File attachments

@vicuna
Copy link
Author

vicuna commented Jan 5, 2006

Comment author: @mauny

Right: `new' should be treated differently in pr_o and pr_r.
See the patch for a fix that doesn't re-introduce the bug I was trying to fix.

@vicuna vicuna closed this as completed Feb 21, 2007
dra27 pushed a commit to dra27/ocaml that referenced this issue Feb 27, 2021
git-svn-id: http://caml.inria.fr/svn/ocaml/version/3.09@7309 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant