Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCaml build fails on platforms with Bourne-derived /bin/sh #4048

Closed
vicuna opened this issue Jun 14, 2006 · 1 comment
Closed

OCaml build fails on platforms with Bourne-derived /bin/sh #4048

vicuna opened this issue Jun 14, 2006 · 1 comment
Labels
bug

Comments

@vicuna
Copy link

vicuna commented Jun 14, 2006

Original bug ID: 4048
Reporter: gerd
Status: closed (set by @damiendoligez on 2006-06-15T17:35:00Z)
Resolution: fixed
Priority: normal
Severity: tweak
Version: 3.09.2
Category: ~DO NOT USE (was: OCaml general)

Bug description

The problematic statement in tools/Makefile is:

unset LC_ALL LC_CTYPE LC_COLLATE LANG

(for opnames.ml). The Bourne shell sets the exit code of this command to 1 if any of the mentioned variables does not exist. If you also try to build with a 'make' that starts the shell with the -e flag (e.g. BSD make), the build will fail.

I got reports for MacOS X, and could reproduce the problem on a NetBSD box.

Solution is easy:

unset LC_ALL LC_CTYPE LC_COLLATE LANG || true
@vicuna
Copy link
Author

vicuna commented Jun 15, 2006

Comment author: @damiendoligez

I can't reproduce the unset behaviour on FreeBSD nor on a modern MacOS X (where /bin/sh has been bash since version 10.2).

I'm still fixing this in the 3.09 branch.

@vicuna vicuna closed this as completed Jun 15, 2006
@vicuna vicuna added the bug label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vicuna