Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to increment Config.ast_impl_magic_number #4156

Closed
vicuna opened this issue Nov 10, 2006 · 1 comment
Closed

Need to increment Config.ast_impl_magic_number #4156

vicuna opened this issue Nov 10, 2006 · 1 comment
Labels

Comments

@vicuna
Copy link

vicuna commented Nov 10, 2006

Original bug ID: 4156
Reporter: berke
Status: closed (set by @damiendoligez on 2006-11-15T11:50:57Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 3.10+dev
Category: ~DO NOT USE (was: OCaml general)

Bug description

Since the parsetree has changed, the corresponding magic numbers should be changed. (I have a file that gives a segmentation fault with ocamldep -pp camlp4o.opt where ocamldep is 3.10 and camlp4o.opt is 3.09.2).

Additional information

% diff -u parsetree.mli ../../ocaml-3.09.2/parsing/parsetree.mli
--- parsetree.mli 2006-04-05 04:28:13.000000000 +0200
+++ ../../ocaml-3.09.2/parsing/parsetree.mli 2005-03-23 04:08:37.000000000 +0100
@@ -10,7 +10,7 @@
(* *)
(***********************************************************************)

-(* $Id: parsetree.mli,v 1.43 2006-04-05 02:28:13 garrigue Exp $ )
+(
$Id: parsetree.mli,v 1.42 2005/03/23 03:08:37 garrigue Exp $ *)

(* Abstract syntax tree produced by parsing *)

@@ -152,7 +152,7 @@

and class_type_field =
Pctf_inher of class_type

  • | Pctf_val of (string * mutable_flag * virtual_flag * core_type * Location.t)
  • | Pctf_val of (string * mutable_flag * core_type option * Location.t)
    | Pctf_virt of (string * private_flag * core_type * Location.t)
    | Pctf_meth of (string * private_flag * core_type * Location.t)
    | Pctf_cstr of (core_type * core_type * Location.t)
    @@ -179,7 +179,6 @@

and class_field =
Pcf_inher of class_expr * string option

  • | Pcf_valvirt of (string * mutable_flag * core_type * Location.t)
    | Pcf_val of (string * mutable_flag * expression * Location.t)
    | Pcf_virt of (string * private_flag * core_type * Location.t)
    | Pcf_meth of (string * private_flag * expression * Location.t)
@vicuna
Copy link
Author

vicuna commented Nov 15, 2006

Comment author: @damiendoligez

Fixed in 3.10+dev17

@vicuna vicuna closed this as completed Nov 15, 2006
@vicuna vicuna added the bug label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant